Skip to content

deps: update c-ares to 1.34.8#64330

Merged
nodejs-github-bot merged 1 commit into
mainfrom
actions/truetools-update-c-ares
Jul 8, 2026
Merged

deps: update c-ares to 1.34.8#64330
nodejs-github-bot merged 1 commit into
mainfrom
actions/truetools-update-c-ares

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

This is an automated update of c-ares to 1.34.8.

@nodejs-github-bot nodejs-github-bot added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies Pull requests that update a dependency file. labels Jul 6, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/net
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jul 6, 2026
@aduh95

aduh95 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor
../src/cares_wrap.cc:1740:3: error: no matching function for call to 'ares_gethostbyaddr'
 1740 |   ares_gethostbyaddr(wrap->channel()->cares_channel(),
      |   ^~~~~~~~~~~~~~~~~~
../deps/cares/include/ares.h:887:19: note: candidate function not viable: no overload of 'Callback' matching 'ares_host_callback' (aka 'void (*)(void *, int, int, const struct hostent *)') for 5th argument
  887 | CARES_EXTERN void ares_gethostbyaddr(ares_channel_t *channel, const void *addr,
      |                   ^
  888 |                                      int addrlen, int family,
  889 |                                      ares_host_callback callback, void *arg);
      |                                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~

@nodejs-github-bot nodejs-github-bot force-pushed the actions/truetools-update-c-ares branch from 9ecba3f to fe01db0 Compare July 8, 2026 08:14
@nodejs-github-bot nodejs-github-bot changed the title deps: update c-ares to 1.34.7 deps: update c-ares to 1.34.8 Jul 8, 2026
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 8, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 8, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 8, 2026
@richardlau richardlau added lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x labels Jul 8, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 8, 2026
@nodejs-github-bot nodejs-github-bot merged commit a18052e into main Jul 8, 2026
71 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator Author

Landed in a18052e

@nodejs-github-bot nodejs-github-bot deleted the actions/truetools-update-c-ares branch July 8, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies Pull requests that update a dependency file. lts-watch-v22.x PRs that may need to be released in v22.x lts-watch-v24.x PRs that may need to be released in v24.x needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants